-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcd-mixin: Limit etcdDatabaseHighFragmentationRatio to 100MB+ #15291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ggustafsson Thanks for raising this, this change itself looks reasonable, can you please ensure your commit is signed to ensure this contribution can be merged.
$ git rebase HEAD~1 --signoff
$ git push --force-with-lease
@jmhbnz Done! |
Thanks for the PR, and it looks good to me. Please fix the test failure. |
Signed-off-by: Göran Gustafsson <[email protected]>
I've fixed the test. Running |
Prometheus rule
etcdDatabaseHighFragmentationRatio
is excessively trigger happy in its current form when the etcd database is small. I think it would be better if the metrics are ignored unless total database size is 100MB+ (or something similar). When the size is small the percentage is large and there isn't a real problem with etcd so this is just creates noise.Signed-off-by: Göran Gustafsson [email protected]