Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd-mixin: Limit etcdDatabaseHighFragmentationRatio to 100MB+ #15291

Merged
merged 1 commit into from
Mar 22, 2023
Merged

etcd-mixin: Limit etcdDatabaseHighFragmentationRatio to 100MB+ #15291

merged 1 commit into from
Mar 22, 2023

Conversation

ggustafsson
Copy link
Contributor

Prometheus rule etcdDatabaseHighFragmentationRatio is excessively trigger happy in its current form when the etcd database is small. I think it would be better if the metrics are ignored unless total database size is 100MB+ (or something similar). When the size is small the percentage is large and there isn't a real problem with etcd so this is just creates noise.

Signed-off-by: Göran Gustafsson [email protected]

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ggustafsson Thanks for raising this, this change itself looks reasonable, can you please ensure your commit is signed to ensure this contribution can be merged.

$ git rebase HEAD~1 --signoff
$ git push --force-with-lease

@ggustafsson
Copy link
Contributor Author

@jmhbnz Done!

@jmhbnz
Copy link
Member

jmhbnz commented Mar 6, 2023

/lgtm

@ahrtr @ptabor Can you please check this small alerting change.

@ahrtr
Copy link
Member

ahrtr commented Mar 6, 2023

Thanks for the PR, and it looks good to me. Please fix the test failure.

@ahrtr
Copy link
Member

ahrtr commented Mar 6, 2023

cc @discordianfish @mtulio

@ggustafsson
Copy link
Contributor Author

I've fixed the test. Running promtool test rules test.yml locally works fine for me.

@ggustafsson
Copy link
Contributor Author

@ahrtr @jmhbnz Is this good to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants