Client: fix check for WithPrefix op #14182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
reviewed
Jun 29, 2022
client/v3/op.go
Outdated
| @@ -391,6 +391,7 @@ func WithPrefix() OpOption { | |||
| return func(op *Op) { | |||
| if len(op.key) == 0 { | |||
| op.key, op.end = []byte{0}, []byte{0} | |||
| op.isOptsWithPrefix = true | |||
There was a problem hiding this comment.
minor comment: Both line 394 and 397 set isOptsWithPrefix as true, so I suggest to move op.isOptsWithPrefix = true to the beginning of the function.
There was a problem hiding this comment.
@ahrtr Good catch, I missed it. Thanks!
Codecov Report
@@ Coverage Diff @@
## main #14182 +/- ##
==========================================
- Coverage 75.47% 75.23% -0.24%
==========================================
Files 455 455
Lines 36846 36846
==========================================
- Hits 27808 27722 -86
- Misses 7314 7381 +67
- Partials 1724 1743 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Make sure that WithPrefix correctly set the flag, and add test. Also, add test for WithFromKey. fixes etcd-io#14056 Signed-off-by: Sahdev Zala <[email protected]>
serathius
approved these changes
Jun 29, 2022
|
@ahrtr @serathius thanks for the quick review! Build is green so merging. |
This was referenced Jul 3, 2022
ahrtr
added a commit
that referenced
this pull request
Jul 3, 2022
…-upstream-release-3.5 Automated cherry pick of #14182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that WithPrefix correctly set the flag, and add test.
Also, add test for WithFromKey.
fixes #14056