[3.5] Update consitent_index when applying fails #13946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
changed the title
ahrtr
force-pushed
the
move_cindex_on_apply_fail_353
branch
from
c870bbb
to
0d0cad1
Compare
ptabor
changed the title
ahrtr
force-pushed
the
move_cindex_on_apply_fail_353
branch
from
0d0cad1
to
1daf1c2
Compare
When clients have no permission to perform whatever operation, then the applying may fail. We should also move consistent_index forward in this case, otherwise the consitent_index may smaller than the snapshot index.
ahrtr
force-pushed
the
move_cindex_on_apply_fail_353
branch
from
1daf1c2
to
5c68f2e
Compare
serathius
approved these changes
Apr 21, 2022
spzala
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport pull/13942 to 3.5.
Original issue: 13937