-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Readme for install etcd client v3 more visibility #13108 #13118
Conversation
There are many developers on the web, confused by how to install etcd v3 for the development of go project. A number of similar errors were encountered, as follows: etcd-io#13108 ``` ➜ ~ go version go version go1.16.5 darwin/amd64 ➜ ~ go get go.etcd.io/etcd/clientv3 go: downloading golang.org/x/net v0.0.0-20201021035429-f5854403a974 # github.com/coreos/etcd/clientv3/balancer/picker go/pkg/mod/github.com/coreos/[email protected]+incompatible/clientv3/balancer/picker/err.go:37:44: undefined: balancer.PickOptions go/pkg/mod/github.com/coreos/[email protected]+incompatible/clientv3/balancer/picker/roundrobin_balanced.go:55:54: undefined: balancer.PickOptions # github.com/coreos/etcd/clientv3/balancer/resolver/endpoint go/pkg/mod/github.com/coreos/[email protected]+incompatible/clientv3/balancer/resolver/endpoint/endpoint.go:114:78: undefined: resolver.BuildOption go/pkg/mod/github.com/coreos/[email protected]+incompatible/clientv3/balancer/resolver/endpoint/endpoint.go:182:31: undefined: resolver.ResolveNowOption ``` There are many examples of confusion here: - etcd-io#12577 - etcd-io#12181 - etcd-io#12068 - etcd-io#11931 ...... So, As suggested by @lilic , I submitted Readme update.
There are many developers on the web, confused by how to install etcd v3 for the development of go project. A number of similar errors were encountered, as follows: etcd-io#13108 ``` ➜ ~ go version go version go1.16.5 darwin/amd64 ➜ ~ go get go.etcd.io/etcd/clientv3 go: downloading golang.org/x/net v0.0.0-20201021035429-f5854403a974 # github.com/coreos/etcd/clientv3/balancer/picker go/pkg/mod/github.com/coreos/[email protected]+incompatible/clientv3/balancer/picker/err.go:37:44: undefined: balancer.PickOptions go/pkg/mod/github.com/coreos/[email protected]+incompatible/clientv3/balancer/picker/roundrobin_balanced.go:55:54: undefined: balancer.PickOptions # github.com/coreos/etcd/clientv3/balancer/resolver/endpoint go/pkg/mod/github.com/coreos/[email protected]+incompatible/clientv3/balancer/resolver/endpoint/endpoint.go:114:78: undefined: resolver.BuildOption go/pkg/mod/github.com/coreos/[email protected]+incompatible/clientv3/balancer/resolver/endpoint/endpoint.go:182:31: undefined: resolver.ResolveNowOption ``` There are many examples of confusion here: - etcd-io#12577 - etcd-io#12181 - etcd-io#12068 - etcd-io#11931 ...... So, As suggested by @lilic , I submitted Readme update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see inline comment for discussion. Thanks!
Install etcd client v3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @forging2012 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
There are many developers on the web, confused by how to install etcd v3 for the development of go project.
A number of similar errors were encountered, as follows:
#13108
There are many examples of confusion here:
......
So, As suggested by @lilic , I submitted Readme update.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.