Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: update to include experimental-apply-warning-duration #12741

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Mar 3, 2021

@codecov-io
Copy link

Codecov Report

Merging #12741 (e9947bc) into master (102c198) will decrease coverage by 4.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12741      +/-   ##
==========================================
- Coverage   71.29%   66.53%   -4.76%     
==========================================
  Files         422      419       -3     
  Lines       33038    32950      -88     
==========================================
- Hits        23553    21924    -1629     
- Misses       7550     8945    +1395     
- Partials     1935     2081     +146     
Flag Coverage Δ
all 66.53% <ø> (-4.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/testutil/recorder.go 0.00% <0.00%> (-80.96%) ⬇️
server/etcdserver/api/v3compactor/revision.go 0.00% <0.00%> (-76.93%) ⬇️
server/auth/options.go 32.43% <0.00%> (-59.46%) ⬇️
server/proxy/tcpproxy/userspace.go 0.00% <0.00%> (-53.85%) ⬇️
server/wal/repair.go 0.00% <0.00%> (-52.84%) ⬇️
client/v2/cluster_error.go 50.00% <0.00%> (-50.00%) ⬇️
server/wal/walpb/record.go 50.00% <0.00%> (-50.00%) ⬇️
server/etcdserver/api/v2store/event_queue.go 50.00% <0.00%> (-50.00%) ⬇️
server/etcdserver/api/v3compactor/periodic.go 39.43% <0.00%> (-49.30%) ⬇️
server/wal/decoder.go 48.64% <0.00%> (-41.90%) ⬇️
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102c198...e9947bc. Read the comment docs.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we missed it adding in 3.5 changelog earlier, glad you covered it :)
Thanks @hexfusion

@hexfusion
Copy link
Contributor Author

test fail unrelated.

@hexfusion hexfusion merged commit f02525c into etcd-io:master Mar 3, 2021
@hexfusion hexfusion deleted the bump-cl-03-03 branch March 3, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants