Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: validate exec command args, remove unused "iptables" wrapper #12491

Merged
merged 3 commits into from
Nov 25, 2020
Merged

*: validate exec command args, remove unused "iptables" wrapper #12491

merged 3 commits into from
Nov 25, 2020

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Nov 25, 2020

To adhere with best practices to prevent arbitrary shell invocations.

@gyuho
tools/etcd-dump-metrics: validate exec cmd args
3eea37c 
To prevent arbitrary command invocations.

Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
pkg/netutil: remove unused "iptables" wrapper
85b61c0 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
CHANGELOG: updates
b40b46f 
Signed-off-by: Gyuho Lee <[email protected]>
spzala
spzala approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks @gyuho - looks great, given CI complete fine.

@gyuho gyuho merged commit 64c409e into etcd-io:master Nov 25, 2020
@gyuho gyuho deleted the better-exec branch November 25, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spzala spzala spzala approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gyuho @spzala