config: grpc gateway #12297
Merged
config: grpc gateway #12297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @mitake |
jingyih
reviewed
Sep 14, 2020
| @@ -411,6 +412,7 @@ func NewConfig() *Config { | |||
| Logger: "zap", | |||
| LogOutputs: []string{DefaultLogOutput}, | |||
| LogLevel: logutil.DefaultLogLevel, | |||
| EnableGRPCGateway: true, | |||
Thank you @jingyih !! |
Currently, the grpc gateway is enabled by default when run the etcd server using command line configuration. However, when provide config through config file, the grpc gateway is disabled by default. We should either use the same approach or at least document this. related #etcd-io#12093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the grpc gateway is enabled by default when run the etcd server
using command line configuration. However, when provide config through
config file, the grpc gateway is disabled by default. We should either use
the same approach or at least document this.
related ##12093