Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for "invalid Go type int" panic #12116

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Add test case for "invalid Go type int" panic #12116

merged 1 commit into from
Jul 21, 2020

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Jul 8, 2020 •
edited
Loading

  • Tested conditions that cause "invalid Go type int" panic

Ref: #12106 (comment)

@ptabor
Copy link
Contributor

ptabor commented Jul 8, 2020

/lgtm - thank you

@bart0sh
etcdserverpb: add TestInvalidGoTypeIntPanic test
f9deb97 
Tested conditions that cause
panic: invalid Go type int for field k8s_io.kubernetes.vendor.go_etcd_io.etcd.etcdserver.etcdserverpb.loggablePutRequest.value_size

Signed-off-by: Ed Bartosh <[email protected]>
@xiang90 xiang90 merged commit e9d16c2 into etcd-io:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptabor ptabor ptabor left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bart0sh @ptabor @xiang90