pkg/fileutil: optimize file stats error #11997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangcong
force-pushed
the
optimize-file-stats-error
branch
from
4a42a54
to
63f51aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #11997 +/- ##
==========================================
+ Coverage 65.50% 65.92% +0.41%
==========================================
Files 403 403
Lines 37320 37320
==========================================
+ Hits 24447 24603 +156
+ Misses 11337 11180 -157
- Partials 1536 1537 +1
Continue to review full report at Codecov.
|
spzala
reviewed
Jun 10, 2020
There was a problem hiding this comment.
@tangcong thanks for this PR. I am working on small related PR and will modify this changelog as needed but lgtm except couple of suggestions
- the changes are for both etcd data directory and the directory path when provided to automatically generate self-signed certificates for TLS connections with clients. So can you please try to cover both in the changelog?
- the desired permission is 700 on Linux but for windows it's 777 so if you can modify the text accordingly that would be great.
Thanks!
tangcong
force-pushed
the
optimize-file-stats-error
branch
from
63f51aa
to
31ef82e
Compare
|
@spzala updated. thanks. |
|
/cc @xiang90 |
tangcong
force-pushed
the
optimize-file-stats-error
branch
from
31ef82e
to
9b444c6
Compare
spzala
approved these changes
Jun 11, 2020
Merged
|
CI failure is not related. |
|
@tangcong can you please cherry pick this to 3.4 and 3.3? Thanks! |
This was referenced Jun 29, 2020
gyuho
added a commit
that referenced
this pull request
Jul 6, 2020
…97-origin-release-3.3 Automated cherry pick of #11997
gyuho
added a commit
that referenced
this pull request
Jul 6, 2020
…97-origin-release-3.4 Automated cherry pick of #11997
This was referenced Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when I try to upgrade etcd cluster from v3.4 to v3.5, I failed to start etcd etcd process. I have to find solution from code, pr #11798 introduces this issue. it is better if we can print detail desired file permission in error log and add breaking change doc for it. thanks. @spzala