go.mod: name packages with go.etcd.io/etcd/v3

[philips]

Attempt to fix #11820

• make works
• ./scripts/genproto.sh makes no changes after running
• make test passes
• ensure bill-of-materials.json is OK
• TEST_OPTS="PASSES='functional'" make test

[codecov-io]

Codecov Report

Merging #11823 into master will decrease coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11823      +/-   ##
==========================================
- Coverage   66.29%   65.89%   -0.40%     
==========================================
  Files         403      403              
  Lines       36984    36984              
==========================================
- Hits        24517    24370     -147     
- Misses      10980    11099     +119     
- Partials     1487     1515      +28     

Impacted Files	Coverage Δ
auth/range_perm_cache.go	68.57% <ø> (ø)
auth/store.go	52.38% <ø> (-3.66%)	⬇️
client/client.go	83.98% <ø> (ø)
client/discover.go	0.00% <ø> (ø)
client/keys.go	55.77% <ø> (-35.68%)	⬇️
client/members.go	85.48% <ø> (ø)
clientv3/auth.go	51.25% <ø> (ø)
clientv3/balancer/balancer.go	86.36% <ø> (ø)
clientv3/client.go	74.05% <ø> (-0.59%)	⬇️
clientv3/clientv3util/util.go	0.00% <ø> (ø)
... and 184 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262c939...c9cdefa. Read the comment docs.

[philips]

Update: resolved in cf9c568

This is weird, consistently getting this error after all of this:

coverage: 28.1% of statements                                                                                                      
Too many goroutines running after all test(s).                                                                                     
1 instances of:                                                                                                                    
go.etcd.io/etcd/v3/pkg/testutil.interestingGoroutines(...)                                                                         
        /home/philips/etcd/pkg/testutil/leak.go:113 +0x8f                                                                          
go.etcd.io/etcd/v3/pkg/testutil.CheckLeakedGoroutine(...)                                                                          
        /home/philips/etcd/pkg/testutil/leak.go:45 +0xe1                                                                           
go.etcd.io/etcd/v3/etcdserver/api/v2v3_test.TestMain(...)                                                                          
        /home/philips/etcd/etcdserver/api/v2v3/main_test.go:40 +0x31c                                                              
main.main()                                                                                                                        
        _testmain.go:104 +0x334  

[philips]

Integration is failing on a test that almost certainly latency flakey:

--- FAIL: TestBalancerUnderNetworkPartitionWatchLeader (3.24s)
2220    network_partition_test.go:266: took too long to detect leader lost

[xiang90]

@philips

Have you tried to write a simple program with etcd/client dependency?

[philips]

What do you mean? What is it you are trying to test?

…

On Tue, Apr 28, 2020, 8:29 AM Xiang Li ***@***.***> wrote: @philips <https://github.com/philips> Have you tried to write a simple program with etcd/client dependency? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11823 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAIGCB3QVJS456WYLNP6UDRO3Y4PANCNFSM4MRN5O7A> .

[xiang90]

What do you mean? What is it you are trying to test?

Something like

import go.etcd.io/etcd/v3/clientv3

func main() {
    _, _ = clientv3.New(...)
   ...
}

Just to make sure the client dependency can be resolved correctly outside the etcd project.

[xiang90]

I gave it a try. It seems working well.

[philips]

OK, thanks. Does it all LGTY then?

…

On Tue, Apr 28, 2020 at 9:01 AM Xiang Li ***@***.***> wrote: I gave it a try. It seems working well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11823 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAIGCB22XXCKBISASNDNGDRO34UPANCNFSM4MRN5O7A> .

[xiang90]

LGTM

[philips]

cc @etcd-io/maintainers-etcd we should all take a look at this go.mod change

[gyuho]

awesome, thank you so much!

[philips]

I am going to merge this at 2pm Pacific today (Tues. 2020-04-28) if there are no objections.

…

On Tue, Apr 28, 2020 at 10:29 AM Gyuho Lee ***@***.***> wrote: ***@***.**** approved this pull request. awesome, thank you so much! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11823 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAIGCAYGSU2KAXUOJHFSFLRO4HAPANCNFSM4MRN5O7A> .

[spzala]

Great!! Thanks @philips lgtm

[gyuho]

@philips Can we update https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.5.md in a separate PR (or just separate commit is good too)?

[philips]

i will add the changelog and try to fix markdown docs before merging

[philips]

@gyuho Take a look at the docs and CHANGELOG entry here: d88d765