Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Etcd downgrade] Add downgrade related api in server side #11715

Merged
merged 2 commits into from
Mar 25, 2020
Merged

[Etcd downgrade] Add downgrade related api in server side #11715

merged 2 commits into from
Mar 25, 2020

Conversation

YoyinZyc
Copy link
Contributor

@YoyinZyc YoyinZyc commented Mar 23, 2020 •
edited
Loading

Issue: #11716

  1. Add downgrade api in rpc.proto to handle requests from client side.
  2. Add DowngradeInfoSet api to membership.proto. It is an internal raft request which will be sent via raft.
    @jingyih @gyuho PHAL

@YoyinZyc YoyinZyc mentioned this pull request Mar 23, 2020
Open
13 tasks
@gyuho
Copy link
Contributor

gyuho commented Mar 24, 2020

Can we check the test failures? Otherwise, pretty simple change. Let's merge after we fix the tests.

@YoyinZyc
Copy link
Contributor Author

Can we check the test failures? Otherwise, pretty simple change. Let's merge after we fix the tests.

The test is flaky. It passed in my repo.
image

Can we rebuild the functional test? I cannot do it.

gyuho
gyuho approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx!

@gyuho gyuho merged commit 71a241e into etcd-io:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuho gyuho gyuho approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoyinZyc @gyuho