transport: separate implied client certificate usage with trusted ca#11703
Closed
dennisdegreef wants to merge 1 commit intoetcd-io:masterfrom
Closed
transport: separate implied client certificate usage with trusted ca#11703dennisdegreef wants to merge 1 commit intoetcd-io:masterfrom
dennisdegreef wants to merge 1 commit intoetcd-io:masterfrom
Conversation
The trusted CA flag currently implies using client certificates. However, since the CA is added to the ones we trust, we can now also use it to validate self-signed certificates between peers for example when only doing 'simple' TLS without client certificates. This also makes the 'client-cert-auth' a more explicit boolean flag. Fixes etcd-io#11124
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trusted CA flag currently implies using client certificates.
However, since the CA is added to the ones we trust, we can now also use it
to validate self-signed certificates between peers for example when only
doing 'simple' TLS without client certificates.
This also makes the 'client-cert-auth' a more explicit boolean flag.
Fixes #11124
This also answers the question at the bottom of #10400