Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy/grpcproxy: add return on error for metrics handler #11694

Merged
merged 1 commit into from
Mar 14, 2020

Conversation

hexfusion
Copy link
Contributor

The gRPC proxy metrics handler will panic on error, return instead.

@retroflexer
Copy link

/lgtm

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks @hexfusion

@hexfusion hexfusion merged commit 7444d3a into etcd-io:master Mar 14, 2020
hexfusion added a commit to hexfusion/etcd that referenced this pull request Mar 15, 2020
hexfusion added a commit to hexfusion/etcd that referenced this pull request Mar 15, 2020
hexfusion added a commit to hexfusion/etcd that referenced this pull request Mar 15, 2020
jingyih added a commit that referenced this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants