Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG-3.5: update from #11564 #11637

Merged
merged 4 commits into from
Mar 25, 2020
Merged

Conversation

eddycjy
Copy link
Contributor

@eddycjy eddycjy commented Feb 19, 2020

added changelog for #11564.

@eddycjy eddycjy changed the title CHANGELOG: update from #11564 CHANGELOG-3.5: update from #11564 Feb 19, 2020
@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #11637 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11637      +/-   ##
==========================================
- Coverage   66.39%   66.37%   -0.02%     
==========================================
  Files         403      403              
  Lines       36753    36753              
==========================================
- Hits        24401    24394       -7     
+ Misses      10857    10854       -3     
- Partials     1495     1505      +10     
Impacted Files Coverage Δ
clientv3/ordering/util.go 26.66% <0.00%> (-73.34%) ⬇️
auth/options.go 57.50% <0.00%> (-35.00%) ⬇️
client/keys.go 70.35% <0.00%> (-21.11%) ⬇️
etcdserver/api/v3rpc/util.go 51.61% <0.00%> (-16.13%) ⬇️
clientv3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
pkg/testutil/recorder.go 77.77% <0.00%> (-3.71%) ⬇️
etcdserver/api/v3election/election.go 61.11% <0.00%> (-2.78%) ⬇️
clientv3/concurrency/election.go 79.68% <0.00%> (-2.35%) ⬇️
etcdserver/v3_server.go 72.39% <0.00%> (-1.96%) ⬇️
etcdserver/api/v3rpc/watch.go 83.85% <0.00%> (-1.76%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a241e...ef57a61. Read the comment docs.

@jpbetz
Copy link
Contributor

jpbetz commented Feb 19, 2020

LGTM

@gyuho
Copy link
Contributor

gyuho commented Mar 25, 2020

Can we rebase

@eddycjy
Copy link
Contributor Author

eddycjy commented Mar 25, 2020

@gyuho I have resolved the conflict.

@gyuho gyuho merged commit 3cea310 into etcd-io:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants