Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/build-binary: Added s390x support for binary release #11358

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

nirmannarang
Copy link
Contributor

scripts/build-binary: Added TARGET_ARCHS for supporting s390x binary build for release
.travis.yml: Added s390x build in all-build target.

@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #11358 into master will decrease coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11358      +/-   ##
==========================================
- Coverage   64.83%   64.23%   -0.61%     
==========================================
  Files         403      403              
  Lines       37969    37969              
==========================================
- Hits        24618    24389     -229     
- Misses      11723    11955     +232     
+ Partials     1628     1625       -3
Impacted Files Coverage Δ
auth/store.go 47.38% <0%> (-20.95%) ⬇️
client/client.go 70.58% <0%> (-13.4%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-11.12%) ⬇️
pkg/tlsutil/tlsutil.go 86.2% <0%> (-6.9%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
pkg/fileutil/purge.go 66% <0%> (-6%) ⬇️
pkg/logutil/zap_grpc.go 47.61% <0%> (-4.77%) ⬇️
proxy/grpcproxy/watcher.go 89.79% <0%> (-4.09%) ⬇️
clientv3/leasing/txn.go 88.09% <0%> (-3.18%) ⬇️
clientv3/concurrency/election.go 79.68% <0%> (-2.35%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63dd73c...cabf594. Read the comment docs.

@wenjiaswe
Copy link
Contributor

cc @xiang90 @hexfusion

@nirmannarang
Copy link
Contributor Author

@xiang90 @hexfusion When can this PR be merged?

@xiang90
Copy link
Contributor

xiang90 commented Dec 2, 2019

lgtm

@xiang90 xiang90 merged commit 18e9e45 into etcd-io:master Dec 2, 2019
nirmannarang added a commit to linux-on-ibm-z/etcd that referenced this pull request Apr 13, 2020
spzala added a commit that referenced this pull request Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants