etcdserver: strip patch version in cluster version metrics #11254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jingyih Looks like some e2e tests are breaking from this change? |
|
I am in favor of backporting to 3.4. e2e metrics test failed due to this change, I will fix it. |
Strip patch version in cluster version metrics.
jingyih
force-pushed
the
strip_patch_version_in_cluster_version_metrics
branch
from
b86e008
to
1333abc
Compare
gyuho
approved these changes
Oct 15, 2019
|
The patch version was always 0 before this anyway, right? Just making sure I understand. |
This is also my understanding. Also, in the log output we never included patch version in cluster version. etcd/etcdserver/api/membership/cluster.go Line 271 in bcc1471 |
|
Great. Thanks for fixing.
…On Mon, Oct 14, 2019 at 5:57 PM Jingyi Hu ***@***.***> wrote:
The patch version was always 0 before this anyway, right? Just making sure
I understand.
This is also my understanding.
Also, in the log output we never included patch version in cluster version.
https://github.com/etcd-io/etcd/blob/bcc147127d1a33d827f78a0d1bf8fe2363a344f2/etcdserver/api/membership/cluster.go#L271
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11254?email_source=notifications&email_token=AAD72RXTXE3W5NH2NKKMANLQOUIPZA5CNFSM4JAT3LD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBHBXIQ#issuecomment-541989794>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD72RT5UAT2ILJQ56ZCDXTQOUIPZANCNFSM4JAT3LDQ>
.
|
wenjiaswe
added a commit
to wenjiaswe/etcd
that referenced
this pull request
Oct 16, 2019
wenjiaswe
added a commit
to wenjiaswe/etcd
that referenced
this pull request
Oct 16, 2019
wenjiaswe
added a commit
to wenjiaswe/etcd
that referenced
this pull request
Oct 16, 2019
wenjiaswe
added a commit
to wenjiaswe/etcd
that referenced
this pull request
Oct 16, 2019
wenjiaswe
added a commit
to wenjiaswe/etcd
that referenced
this pull request
Oct 16, 2019
wenjiaswe
added a commit
to wenjiaswe/etcd
that referenced
this pull request
Oct 16, 2019
wenjiaswe
added a commit
to wenjiaswe/etcd
that referenced
this pull request
Oct 17, 2019
hexfusion
pushed a commit
to openshift/etcd
that referenced
this pull request
Mar 20, 2020
hexfusion
pushed a commit
to openshift/etcd
that referenced
this pull request
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gyuho We discussed about stripping patch version in cluster version metrics.
Example output: