Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #11147 #11148

Conversation

spzala
Copy link
Member

@spzala spzala commented Sep 13, 2019

Cherry pick of #11147 on release-3.4.

#11147: embed: expose ZapLoggerBuilder

This exposes the ZapLoggerBuilder in the embed.Config to allow for
custom loggers to be defined and used by embedded etcd.

Fixes etcd-io#11144
@gyuho gyuho merged commit 21dcadc into etcd-io:release-3.4 Sep 13, 2019
@gyuho
Copy link
Contributor

gyuho commented Sep 13, 2019

@spzala Can we also add CHANGELOG? Thanks

@spzala
Copy link
Member Author

spzala commented Sep 13, 2019

@gyuho thank you and sure will add!

spzala added a commit to spzala/etcd that referenced this pull request Sep 13, 2019
@xxx7xxxx
Copy link

Don't get it. Even we exposed the ZapLoggerBuilder, we still can't use it to do useful jobs like assigning variables to cfg.logger, cfg.loggerCore. What's the point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants