Automated cherry pick of #11147 #11148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes the ZapLoggerBuilder in the embed.Config to allow for custom loggers to be defined and used by embedded etcd. Fixes etcd-io#11144
gyuho
approved these changes
Sep 13, 2019
|
@spzala Can we also add CHANGELOG? Thanks |
|
@gyuho thank you and sure will add! |
spzala
added a commit
to spzala/etcd
that referenced
this pull request
Sep 13, 2019
Update from etcd-io#11147 and etcd-io#11148
|
Don't get it. Even we exposed the ZapLoggerBuilder, we still can't use it to do useful jobs like assigning variables to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #11147 on release-3.4.
#11147: embed: expose ZapLoggerBuilder