Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd: Replace ghodss/yaml with sigs.k8s.io/yaml #10718

Merged
merged 1 commit into from
May 29, 2019

Conversation

rohitsardesai83
Copy link
Contributor

To remove the dependency on ghodss/yaml. Replaced this dependency with sigs.k8s.io/yaml.
This wil help to remove the ghodss/yaml dependency from main kubernetes repository.

See :

@xiang90
Copy link
Contributor

xiang90 commented May 14, 2019

@rohitsardesai83

I see

go: sigs.k8s.io/[email protected]: unrecognized import path "sigs.k8s.io/yaml" (https fetch: Get https://sigs.k8s.io/yaml?go-get=1: net/http: TLS handshake timeout)

happened in test cases. Can you check why? details: https://travis-ci.com/etcd-io/etcd/jobs/198142245

@rohitsardesai83
Copy link
Contributor Author

@rohitsardesai83

I see

go: sigs.k8s.io/[email protected]: unrecognized import path "sigs.k8s.io/yaml" (https fetch: Get https://sigs.k8s.io/yaml?go-get=1: net/http: TLS handshake timeout)

happened in test cases. Can you check why? details: https://travis-ci.com/etcd-io/etcd/jobs/198142245

@xiang90 , I observed this failure in my PR as well : #10687 , but when I ran the test locally , it is able to pull the dependency correctly. I am not sure why the timeout occurs intermittently for this dependency in the CI.

@@ -126,7 +126,7 @@ import:
- package: gopkg.in/cheggaaa/pb.v1
version: v1.0.2
- package: gopkg.in/yaml.v2
version: cd8b52f8269e0feb286dfeef29f8fe4d5b397e0b
version: 51d6538a90f86fe93ac480b35f37b2be17fef232
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigs.k8s.io/yaml uses this version of gopkg.in/yaml.v2.

@rohitsardesai83
Copy link
Contributor Author

@xiang90 , @gyuho , could you please help reviewing this PR ?

@gyuho
Copy link
Contributor

gyuho commented May 29, 2019

@rohitsardesai83 Can you create a separate PR to highlight this in changelog?

@gyuho
Copy link
Contributor

gyuho commented May 29, 2019

@rohitsardesai83 You can just copy the line from CHANGELOG-3.4.

@gyuho gyuho merged commit b0babe5 into etcd-io:release-3.3 May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants