-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcd: Replace ghodss/yaml with sigs.k8s.io/yaml #10718
Conversation
I see
happened in test cases. Can you check why? details: https://travis-ci.com/etcd-io/etcd/jobs/198142245 |
@xiang90 , I observed this failure in my PR as well : #10687 , but when I ran the test locally , it is able to pull the dependency correctly. I am not sure why the timeout occurs intermittently for this dependency in the CI. |
e517a6e
to
8ed3e70
Compare
@@ -126,7 +126,7 @@ import: | |||
- package: gopkg.in/cheggaaa/pb.v1 | |||
version: v1.0.2 | |||
- package: gopkg.in/yaml.v2 | |||
version: cd8b52f8269e0feb286dfeef29f8fe4d5b397e0b | |||
version: 51d6538a90f86fe93ac480b35f37b2be17fef232 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sigs.k8s.io/yaml uses this version of gopkg.in/yaml.v2.
@rohitsardesai83 Can you create a separate PR to highlight this in changelog? |
@rohitsardesai83 You can just copy the line from CHANGELOG-3.4. |
To remove the dependency on ghodss/yaml. Replaced this dependency with sigs.k8s.io/yaml.
This wil help to remove the ghodss/yaml dependency from main kubernetes repository.
See :
github.com/ghodss/yaml
withsigs.k8s.io/yaml
#10687.This pull request was raised against the master branch.
Kubernetes uses etcd 3.3, so need to backport this fix to 3.3.