Merge pull request #12092 from mitake/warn

etcdmain: let grpc proxy warn about insecure-skip-tls-verify
etcd-io · Jun 29, 2020 · 7f726db · 7f726db
2 parents 01f1109 + db2165d
commit 7f726db
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/etcdmain/grpc_proxy.go b/etcdmain/grpc_proxy.go
@@ -296,6 +296,9 @@ func newClientCfg(lg *zap.Logger, eps []string) (*clientv3.Config, error) {
 			return nil, err
 		}
 		clientTLS.InsecureSkipVerify = grpcProxyInsecureSkipTLSVerify
+		if clientTLS.InsecureSkipVerify {
+			lg.Warn("--insecure-skip-tls-verify was given, this grpc proxy process skips authentication of etcd server TLS certificates. This option should be enabled only for testing purposes.")
+		}
 		cfg.TLS = clientTLS
 		lg.Info("gRPC proxy client TLS", zap.String("tls-info", fmt.Sprintf("%+v", tls)))
 	}