Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go to 1.24.0 #71

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Bump go to 1.24.0 #71

merged 1 commit into from
Feb 21, 2025

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Feb 15, 2025 •
edited
Loading

Upgrades Go to 1.24.0.

Part of etcd-io/etcd#19417.

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ivanvc ivanvc force-pushed the update-to-go-1.24.0 branch from 92750ec to b3b954c Compare February 15, 2025 00:27
This was referenced Feb 15, 2025
Open
Merged
@ivanvc ivanvc force-pushed the update-to-go-1.24.0 branch 2 times, most recently from 1b1c490 to b148823 Compare February 18, 2025 20:02
@ivanvc ivanvc mentioned this pull request Feb 18, 2025
Closed
@ivanvc ivanvc force-pushed the update-to-go-1.24.0 branch 3 times, most recently from 6e11d34 to fe5c903 Compare February 18, 2025 21:32
@ivanvc ivanvc force-pushed the update-to-go-1.24.0 branch from fe5c903 to 604efd9 Compare February 18, 2025 21:37
@ivanvc
Copy link
Member Author

ivanvc commented Feb 20, 2025 •
edited
Loading

The lint job will fail until the kubekins-e2e image provides Go 1.24.0.

Never mind, with #82, we don't need it.

@ivanvc ivanvc force-pushed the update-to-go-1.24.0 branch from 604efd9 to 0f73df2 Compare February 20, 2025 23:40
@ivanvc
Copy link
Member Author

ivanvc commented Feb 21, 2025

/test all

@ivanvc ivanvc marked this pull request as ready for review February 21, 2025 07:06
@ahrtr
Copy link
Member

ahrtr commented Feb 21, 2025

Is this PR still WIP? If not, please remove "WIP" from the title, thx

@ivanvc ivanvc changed the title [WIP] Bump to go 1.24.0 Bump to go 1.24.0 Feb 21, 2025
@ivanvc ivanvc changed the title Bump to go 1.24.0 Bump go to 1.24.0 Feb 21, 2025
@ivanvc
Copy link
Member Author

ivanvc commented Feb 21, 2025

Is this PR still WIP? If not, please remove "WIP" from the title, thx

Oops, forgot to remove it

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit a7b0bc2 into etcd-io:main Feb 21, 2025
5 checks passed
@ivanvc ivanvc deleted the update-to-go-1.24.0 branch February 21, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
approved size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanvc @k8s-ci-robot @ahrtr