Skip to content

Conversation

@ivanvc
Copy link
Member

@ivanvc ivanvc commented Jun 24, 2025

  • Create a template to simplify executing tests without repetition.
  • Run cross-compilation tests for Windows on Ubuntu (Linux), as every platform is being cross-compiled as a sanity check, it could also be done using Linux, and simplify the template.
  • Remove the GolangCI lint action, as it is linting in Linux (as this is not using QEMU, but only cross-compilation), and there's no benefit to adding this step, as it's already checked in other workflows.

Follow up on #986.

* Create a template to simplify executing tests without repetition.
* Run cross-compilation tests for Windows on Ubuntu (Linux), as every
  platform is being cross-compiled as a sanity check, it could also be
  done using Linux, and simplify the template.
* Remove the GolangCI lint action, as it is linting in Linux (as this is
  not using QEMU, but only cross-compilation), and there's no benefit to
  adding this step, as it's already checked in other workflows.

Signed-off-by: Ivan Valdes <[email protected]>
@Elbehery
Copy link
Member

LGTM

thanks @ivanvc

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the cleanup!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 467bd76 into etcd-io:main Jun 25, 2025
43 checks passed
@ahrtr ahrtr mentioned this pull request Jun 25, 2025
@ivanvc ivanvc deleted the use-temmplate-for-cross-build-tests branch June 25, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants