bucket: add count guard for branch pages in Stats (backport 1.4)#1172
Merged
ahrtr merged 1 commit intoetcd-io:release-1.4from Mar 31, 2026
Merged
Conversation
Bucket.Stats() panics with index-out-of-range when iterating branch pages with zero elements. The leaf page path has a Count() != 0 guard, but the branch page path accesses BranchPageElement(Count() - 1) without one. Wrap the branch element access in the same guard. Fixes etcd-io#1170 Signed-off-by: Quoc Bui <buiviquoc@gmail.com>
quocvibui
added a commit
to quocvibui/bbolt
that referenced
this pull request
Mar 30, 2026
Add changelog entries for the backported fix to 1.4 (etcd-io#1172) and 1.3 (etcd-io#1173). Signed-off-by: Quoc Bui <buiviquoc@gmail.com>
This was referenced Mar 30, 2026
Member
|
/ok-to-test |
ahrtr
approved these changes
Mar 31, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, quocvibui The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1171 to
release-1.4.Bucket.Stats()panics with an index-out-of-range error when iterating branch pages with a zero element count. Wraps the branch element access in the samep.Count() != 0guard used for leaf pages.Fixes #1170
Signed-off-by: Quoc Bui buiviquoc@gmail.com