internal/common: added PgidSet to replace usages of map[Pgid]bool #1087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup of the work carried out in #1082.
In the
freelistpackage I foundpidSetthat, if extended to haveAdd,Has,Removemethods and made public, can replace all usages ofmap[Pgid]boolandmap[Pgid]struct{}Let me know if this new
PgidSettype looks good to you or if you prefer to stick to usingmap[string]struct{}instead.