Skip to content

Conversation

@arturmelanchyk
Copy link
Contributor

@arturmelanchyk arturmelanchyk commented Sep 11, 2025

As a followup of the work carried out in #1082.

In the freelist package I found pidSet that, if extended to have Add, Has, Remove methods and made public, can replace all usages of map[Pgid]bool and map[Pgid]struct{}
Let me know if this new PgidSet type looks good to you or if you prefer to stick to using map[string]struct{} instead.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arturmelanchyk
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants