Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use go tools from go 1.24 #219

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Mar 2, 2025

Description

Use go1.24 capabilites to handle tools: https://tip.golang.org/doc/go1.24

It also extends revive rules with early-return and superfluous-else

Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35 mmorel-35 changed the title chore: enable early-return and superfluous-else rules from revive chore: use go tools from go 1.24 Mar 2, 2025
@mmorel-35 mmorel-35 force-pushed the revive/early-return+superfluous-else branch from 2daf1d6 to 6d88c6d Compare March 2, 2025 21:43
@mmorel-35 mmorel-35 marked this pull request as ready for review March 2, 2025 21:44
@siyuanfoundation
Copy link
Contributor

This is cool!
Thanks @mmorel-35 !

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmorel-35, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@siyuanfoundation siyuanfoundation merged commit f95b828 into etcd-io:main Mar 3, 2025
3 checks passed
@mmorel-35 mmorel-35 deleted the revive/early-return+superfluous-else branch March 3, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants