-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll Infinite in ngTable #560
base: master
Are you sure you want to change the base?
Conversation
Implementation de scrolling infinite in ngTable. Not jQuery or plugins, native AngularJS.
@brunoosilva hi, good work we appreciate it. But in order to merge your pull request you need to make changes to src files. Thanks |
@Iyel , I did not, can you help me? |
Any news about this feature? |
@Iyel pull request files to scroll infinite, in src files. Sorry!
I not correct pull request in project, but now i mage a correct request, i hope. |
Ops, missing some files!
Hi @brunoosilva, There are couple of pull requests (#560, #656) that point to the need to add more pager options. However, we need to refactor these existing one first. Also your directive makes the existing pager options redundant for those apps that use infinite scroll. It seems we need to separate out pager options and page generation logic from Now, all we need is someone to take the lead on this and:
C |
I want to try it out in my project, I cloned, and loaded your fork @brunoosilva in my project, how do I set it up to see it in action? Thanks |
@Rogerkael I left the above steps, how to use. Good luck |
Hello,
I managed to implement the "Scroll Infinite" in "ngTable", had little change in the current code, only adding a new "directive" and a new parameter "
isPagination
" that you guys can improve if possible.Hope this helps everyone, because it helps the mobile also. Below is an explanation of how to use the new featured.
1 - In tag "
<table>
" add the attribute "ng-table-pagination-scroll
", noting that the "ng-table
" attribute is required.2 - If you want the loading, add after the table and remember to use the "
$ scope.isLoading = true | false;
" at the right times. The styles are preloaded, but feel free if you want to change them.3 - I leave below an example of call, to run the "Scroll Infinite", but feel free to improve.
I hope you got something good in the library, and we can improve more and more. Sorry for my English horrible because I am Brazilian.
Hugs