Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is v4.0.0 not stable? #953

Closed
kyrylkov opened this issue Jan 5, 2017 · 6 comments
Closed

Is v4.0.0 not stable? #953

kyrylkov opened this issue Jan 5, 2017 · 6 comments

Comments

@kyrylkov
Copy link

kyrylkov commented Jan 5, 2017

Is v4.0.0 not stable and v3.0.1 the latest stable as of 2007-01-05?

@christianacca
Copy link
Collaborator

christianacca commented Jan 5, 2017 via email

@kyrylkov
Copy link
Author

kyrylkov commented Jan 5, 2017

Does ng-table use semantic versioning?

If yes, it's understood that 4.0.0 has some breaking changes.

What's confusing in this case is that npm out shows that 3.0.1 is the latest, when ~4.0.0 is required in package.json:

Package   Current  Wanted  Latest  
ng-table    4.0.0   4.0.0   3.0.1

Also the fact that 4.0.0 is marked as a pre-release in GitHub just adds to the confusion.

I suggest you release 4.0.1 and mark it as a regular release so it becomes the latest release solving both issues outlined above.

@ccrowhurstram
Copy link
Contributor

ccrowhurstram commented Jan 6, 2017

The project uses semantic-release to automate version number assignment and to publish to npm. This dictates certain conventions.

One of which is NOT to use pre-release version numbers but instead use release channels via npm dist-tags to indicate whether the version is considered "battle tested". Interestingly, this is what the npm team uses itself to version the npm client.

For ng-table, this leads to the following...

Publishing work flow

  1. a new version is published with a version number that reflects whether this version introduces a fix, feature, or breaking change (eg 4.0.0)
  2. this new version is published with a dist-tag of next
    • note: any new installs of ng-table will continue to use the current version tagged with latest (eg 3.0.1)
  3. the release on github is marked as pre-release
    • the alternative would be to not add a pre-release marker - I'm not sure that is a good idea, and it's not something that the npm project follows
  4. a period of time elapses where a small(er) proportion of app's have installed / updated to this next version; no adverse feedback is received
  5. the dist-tag of this version is now changed to latest and the pre-release marker is removed from github
  6. any new installs will use this version (eg 4.0.0)

Unfortunately tooling is not perfect. npm doesn't place meaning on the dist-tags and so npm out says what it says.

C

@christianacca
Copy link
Collaborator

I've added a small clarification to the readme that points to this conversation.

Hopefully, that will clear up some of the confusion for others

@kyrylkov
Copy link
Author

kyrylkov commented Jan 6, 2017

That's great. Thank you for investing your time into this project.

@christianacca
Copy link
Collaborator

Cool. I'll close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants