agent: use touch publications for expanded draft specs #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Touch publications are kind of a perfect fit for expanded specs in user-initiated publications. Expanded specs are never modified by the publication, and it's annoying to add publication specs for things that users haven't intended to publish. Using `is_touch: true` on expanded specs prevents the creation of unnecessary publication specs. It also avoids unnecessary modification of `last_pub_id`, so there will be less chance of `ExpectPubIdMismatch` errors. The touched specs are still validated, which serves the original purpose of spec expansion. Resolves #1643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Touch publications are kind of a perfect fit for expanded specs in user-initiated publications. Expanded specs are never modified by the publication, and it's annoying to add publication specs for things that users haven't intended to publish. Using
is_touch: trueon expanded specs prevents the creation of unnecessary publication specs. It also avoids unnecessary modification oflast_pub_id, so there will be less chance ofExpectPubIdMismatcherrors. The touched specs are still validated, which serves the original purpose of spec expansion.Resolves #1643
Workflow steps:
last_pub_idof the capture and materialization have not changed, but thelast_build_idhaspublication_specsare added for the capture and materialization, only the collectionNotes for reviewers:
This is a follow up change from #1629 , which added the "touch" capability. I wanted to break this out as a separate PR just to limit the scope of changes in any one deployment.
This change is