flowctl: use max build_id for validating local specs #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation logic was changed in a prior commit to error if the `last_build_id` of a live spec is greater than the current build id. This change was supposed to go along with that, but got missed. Using the maximum id value ensures that we never get errors due to the build id being superseded.
psFried
added
bug
jshearer
approved these changes
Sep 17, 2024
github-actions bot
pushed a commit
to estuary/homebrew-flowctl
that referenced
this pull request
Sep 19, 2024
## What's Changed * Batch draft spec upserts, rather than attempting to paginate the response by @jshearer in estuary/flow#1629 * use max build_id for validating local specs by @psFried in estuary/flow#1636 * Update pagination to use 0-indexed inclusive ranges, and page by response length rather than fixed page size. by @jshearer in estuary/flow#1637
github-actions bot
pushed a commit
to estuary/homebrew-flowctl
that referenced
this pull request
Sep 19, 2024
## What's Changed * Batch draft spec upserts, rather than attempting to paginate the response by @jshearer in estuary/flow#1629 * use max build_id for validating local specs by @psFried in estuary/flow#1636 * Update pagination to use 0-indexed inclusive ranges, and page by response length rather than fixed page size. by @jshearer in estuary/flow#1637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation logic was changed in a prior commit to error if the
last_build_idof a live spec is greater than the current build id. This change was supposed to go along with that, but got missed. Using the maximum id value ensures that we never get errors due to the build id being superseded.This change is