-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed multiline decision for object patterns with rest elements #408
fixed multiline decision for object patterns with rest elements #408
Conversation
Sync with escodegen/master
@michaelficarra will happy if you check it |
@michaelficarra please check this. 2 months left since PR has created. I need fix for this, because my tool should support this syntax. |
Related issue |
Also, I think, this package needs more active maintainers. |
@michaelficarra updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this problem is actually a little more complicated. The whole multiline
determination just doesn't seem to account for RestElement. If you see below, property.shorthand
is being tested without first checking property.type
. I think we need to add a test there as well and a test here for property.argument
being an Identifier
if property.type
is RestElement
.
Can you show me case when |
When will this be fixed? I experience the same problem atm. |
For me it's exactly this issue as well: javascript-obfuscator/javascript-obfuscator#607 Would be great if this could be merged soon @michaelficarra |
@sanex3339 You're right, that should be sufficient now. Thanks for the contribution. |
thx a lot @michaelficarra 👍 |
Thank you! |
Fixed error during code generation for object pattern single rest-element property