Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Import variable binding for esprima 2 #257

Merged

Conversation

adamjmcgrath
Copy link
Contributor

eg import {foo as bar} from "baz";

The imported field refers to the name of the export imported from the module. The local field refers to the binding imported into the local module scope. If it is a basic named import, such as in import {foo} from "mod", both imported and local are equivalent Identifier nodes; in this case an Identifier node representing foo. If it is an aliased import, such as in import {foo as bar} from "mod", the imported field is an Identifier node representing foo, and the local field is an Identifier node representing bar.

See: https://github.com/estree/estree/blob/master/es6.md#importspecifier

@Constellation
Copy link
Member

lgtm

Constellation added a commit that referenced this pull request Sep 25, 2015
Fix Import variable binding for esprima 2
@Constellation Constellation merged commit fc99fcd into estools:master Sep 25, 2015
@Constellation
Copy link
Member

Thank you :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants