snprintf use stack memory

estkme-group · Nov 23, 2023 · 67b0ab8 · 67b0ab8
1 parent 760da11
commit 67b0ab8
Showing 1 changed file with 2 additions and 11 deletions.
diff --git a/interface/apdu/pcsc.c b/interface/apdu/pcsc.c
@@ -379,30 +379,21 @@ static int pcsc_list_iter(int index, const char *reader, void *userdata)
 {
     cJSON *json = userdata;
     cJSON *jreader;
+    char index_str[16];
 
-    char *index_str;
+    snprintf(index_str, sizeof(index_str), "%d", index);
 
     jreader = cJSON_CreateObject();
     if (!jreader)
     {
         return -1;
     }
 
-    index_str = malloc(16);
-    if (!index_str)
-    {
-        return -1;
-    }
-
-    snprintf(index_str, 16, "%d", index);
-
     if (!cJSON_AddStringToObject(jreader, "env", index_str))
     {
         return -1;
     }
 
-    free(index_str);
-
     if (!cJSON_AddStringToObject(jreader, "name", reader))
     {
         return -1;