Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Update typemap to use orphanage-rs impl #275

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

No9
Copy link
Contributor

@No9 No9 commented Sep 3, 2022

Moves the typemap to point at the orphanage-rs implementation so we can address CVEs
Signed-off-by: Anton Whalley [email protected]

@No9
Copy link
Contributor Author

No9 commented Sep 19, 2022

@estk This looks like it's failing due to a cargo error that first surfaced in the last accepted PR
https://github.com/estk/log4rs/actions/runs/2980011153/jobs/4777432111
Do you have a view on how you would like this resolved e.g. bump the workflow to support a later version of Rust?
Thanks

@estk
Copy link
Owner

estk commented Oct 11, 2022

@No9 sorry this took so long, can you rebase?

@estk estk changed the base branch from master to estk/typemap_rebase October 11, 2022 18:42
@estk estk merged commit db2606a into estk:estk/typemap_rebase Oct 11, 2022
estk added a commit that referenced this pull request Oct 11, 2022
* bump to 1.56 for edition 2021

* bump to 1.56 for edition 2021 support

* fix:Update typemap to use orphanage-rs impl (#275)

Signed-off-by: Anton Whalley <[email protected]>

Signed-off-by: Anton Whalley <[email protected]>

Signed-off-by: Anton Whalley <[email protected]>
Co-authored-by: Anton Whalley <[email protected]>
@No9
Copy link
Contributor Author

No9 commented Oct 11, 2022

Thanks for landing @estk

@estk
Copy link
Owner

estk commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants