fix: ensure patch jobs have different selector labels

Ensure the patch jobs have different labels/label values than the deployment so HPA does not consider the patch jobs in its calculations creating errors. Thanks to @jurgenweber fixes estahn/k8s-image-swapper#124
estahn · Jan 30, 2023 · a59ea87 · a59ea87
1 parent 231b9a3
commit a59ea87
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/charts/k8s-image-swapper/templates/_helpers.tpl b/charts/k8s-image-swapper/templates/_helpers.tpl
@@ -53,6 +53,11 @@ Selector labels
 {{- define "k8s-image-swapper.selectorLabels" -}}
 app.kubernetes.io/name: {{ include "k8s-image-swapper.name" . }}
 app.kubernetes.io/instance: {{ .Release.Name }}
+{{- if contains "/job-patch/" .Template.Name }}
+app.kubernetes.io/component: job-patch
+{{- else }}
+app.kubernetes.io/component: app
+{{- end }}
 {{- end }}
 
 {{/*

diff --git a/charts/k8s-image-swapper/templates/deployment.yaml b/charts/k8s-image-swapper/templates/deployment.yaml
@@ -19,7 +19,6 @@ spec:
         {{- toYaml . | nindent 8 }}
       {{- end }}
       labels:
-        # Includes selectorLabels
         {{- include "k8s-image-swapper.labels" . | nindent 8 }}
     spec:
       {{- with .Values.imagePullSecrets }}