Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show only valid esp idf setups #908

Merged
merged 5 commits into from
Mar 30, 2023
Merged

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Mar 14, 2023

Description

Shows only valid ESP-IDF setups by validating them before showing them in the Setup wizard

Fixes #906

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Manual testing

Test Configuration:

  • ESP-IDF Version: 5.1
  • OS (Windows,Linux and macOS): MacOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Mar 14, 2023
@github-actions
Copy link

github-actions bot commented Mar 14, 2023

Download the artifacts for this pull request:

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments related to some small changes that I think could improve the UX

src/views/setup/ExistingSetup.vue Outdated Show resolved Hide resolved
src/views/setup/ExistingSetup.vue Show resolved Hide resolved
src/views/setup/ExistingSetup.vue Outdated Show resolved Hide resolved
src/views/setup/ExistingSetup.vue Outdated Show resolved Hide resolved
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndriiFilippov
Copy link
Collaborator

Hi @brianignacio5 !

Tested under:
OS - Windows 10
VS Code - 1.76.2

Use existing setup -> able to see actual esp-idf setup
LGTM 👍

@brianignacio5 brianignacio5 merged commit df4269b into master Mar 30, 2023
@brianignacio5 brianignacio5 deleted the bugfix/valid-existing-setup branch March 30, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension keeps old settings when choosing USE EXISTING SETUP (VSC-1062)
3 participants