-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show only valid esp idf setups #908
Conversation
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few comments related to some small changes that I think could improve the UX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @brianignacio5 ! Tested under: Use existing setup -> able to see actual esp-idf setup |
Description
Shows only valid ESP-IDF setups by validating them before showing them in the Setup wizard
Fixes #906
Type of change
Please delete options that are not relevant.
How has this been tested?
Manual testing
Test Configuration:
Checklist