Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cmds for Codespaces and redirect Flash monitor to Web extension #1297

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

brianignacio5
Copy link
Collaborator

… web extension

Description

Add UIKind.Web validation for Codespaces to disable commands not available in Browser or Codespaces and redirect Flash and monitor commands to ESP-IDF Web extension

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

Open VSCode Extension codespace test in Codespaces. Uninstall the ESP-IDF extension that was pre installed. Load this PR vsix installer into the current Codespaces directory and install vsix from there to Codespaces (install from local doesn't work for me).

  1. Click on ESP-IDF: Flash your project or Flash icon from status bar, the extension will call the ESP-IDF Web extension flash command. Same for ESP-IDF: Monitor your device to call web extension monitor command.
  2. Click on any commands that should work in browser like ESP-IDF: Build, flash and monitor. You should receive a notification error message that command is not available in Web.
  3. Observe results.
  • Expected behaviour:

  • Expected output:

How has this been tested?

Manual testing using steps above.

Test Configuration:

  • ESP-IDF Version: 5.3
  • OS (Windows,Linux and macOS): Codespaces

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added this to the 1.9.0 milestone Aug 30, 2024
@brianignacio5 brianignacio5 self-assigned this Aug 30, 2024
Copy link

github-actions bot commented Aug 30, 2024

Download the artifacts for this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant