Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use workspace folder uri in serial port #1167

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Mar 21, 2024

Description

Fix the need to select workspace folder on serial port selection

Fixes #1166

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Select port to use"
  2. Execute action.
  3. Observe results. No dropdown to select workspace should be shown.
  • Expected behaviour:

  • Expected output:

Test Configuration:

  • ESP-IDF Version: 5.2
  • OS (Windows,Linux and macOS): macOS

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Mar 21, 2024
@brianignacio5 brianignacio5 added this to the v1.7.1 milestone Mar 21, 2024
Copy link

Download the artifacts for this pull request:

@brianignacio5 brianignacio5 merged commit a3520ba into master Mar 22, 2024
6 checks passed
@brianignacio5 brianignacio5 deleted the bugfix/serialport-workspace branch March 22, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't change port on macos (VSC-1330)
1 participant