-
Notifications
You must be signed in to change notification settings - Fork 319
update notification mode to enum add saveScope change message #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small request for a missing dot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
822e69b
to
0125e3a
Compare
@brianignacio5 hi ! Tested: Click on ESP-IDF: Select where to save configuration settings -> select "Workspace Folder" -> Click on ESP-IDF: Select output and notification mode -> select "Notification" -> error: |
Fixed |
@brianignacio5 hi ! able to build. Will you separate the "Workspace" and "Workspace Folder" ? As we discussed like "every workspace could contain many projects" , so we could set individual notification settings for each of them ? |
Yes that is how it is right now. |
Description
Add notification for
ESP-IDF: Select where to save configuration settings
command on successful update.Modify
idf.notificationSilentMode
toidf.notificationMode
to allow 4 modes of user notifications and output focus: All, Notifications only, output focus only or Silent. AddESP-IDF: Select output and notification mode
to select notification mode.Fixes VSC-1225
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
ESP-IDF: Select where to save configuration settings
and see success notificationESP-IDF: Select output and notification mode
, select notification and output mode.idf.notificationMode
is set toAll
orOutput
.idf.notificationMode
is set toAll
orNotification
.idf.notificationMode
is set toAll
orNotification
.idf.notificationMode
is set toAll
orOutput
.Test Configuration:
Checklist