Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add execPath as config variable #1003

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Jul 4, 2023

Description

Add ${execPath} as supported variable substitution in configuration settings.

Fixes IDF espressif/vscode-esp-idf-extension#1024

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Use ${execPath} in a configuration setting and run one of the extension commands with it.
  2. Execute action.
  3. Observe results. The variable should be replaced properly.

How has this been tested?

Manual testing using idf.customTask and executing custom task

Test Configuration:

  • ESP-IDF Version: 5.0
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Download the artifacts for this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolving ${execPath} correctly in user's settings.json (IDFGH-10299) (VSC-1165)
1 participant