Skip to content

Conversation

@hfudev
Copy link
Member

@hfudev hfudev commented Jul 11, 2022

fix regression from #98

@hfudev hfudev self-assigned this Jul 11, 2022
@hfudev
Copy link
Member Author

hfudev commented Jul 11, 2022

@Ouss4 PTAL.

@hfudev
Copy link
Member Author

hfudev commented Jul 11, 2022

yanked 0.7.4

Copy link
Contributor

@Ouss4 Ouss4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah so it ended up conflicting with the function... I did have concerns that this may happen.
Thanks for the fix @hfudev.

@hfudev hfudev force-pushed the fix/erase_flash_cli_conflict_with_function branch from e11f9ff to 5a215c6 Compare July 11, 2022 09:16
@hfudev
Copy link
Member Author

hfudev commented Jul 11, 2022

added some tests

@hfudev hfudev merged commit bbd1512 into main Jul 11, 2022
@hfudev hfudev deleted the fix/erase_flash_cli_conflict_with_function branch August 23, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants