Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xtensa] Fix fp16 conversion #92

Open
wants to merge 1 commit into
base: xtensa_release_17.0.1
Choose a base branch
from

Conversation

gerekon
Copy link
Collaborator

@gerekon gerekon commented Mar 28, 2024

No description provided.

@gerekon gerekon changed the title [Xtensa] Disable fp16 conversion intrinsics [Xtensa] Fix fp16 conversion Mar 28, 2024
@gerekon
Copy link
Collaborator Author

gerekon commented Mar 29, 2024

@andreisfr @sstefan1 PTAL
@kassane FYI

@sstefan1
Copy link
Collaborator

I suggest using update_llc_test_checks.py for generating check lines. Otherwise LGTM!

@gerekon
Copy link
Collaborator Author

gerekon commented Apr 1, 2024

@sstefan1

I suggest using update_llc_test_checks.py for generating check lines. Otherwise LGTM!

Actually I used it to generate initial test case. But after that I removed instructions and left only ones related to conversion functions calls as it is done for ARM. But looks like that code is 9 years old, so it was written before the first version of update_llc_test_checks.py was implemented.

So. Ok. I will re-generate checks for easier maintenance in future.

@kassane
Copy link

kassane commented Apr 1, 2024

This change didn't give me the error mentioned in the issue.

But, now:

$> ./out/zig-x86_64-linux-musl-baseline/zig cc -target xtensa-freestanding -mcpu=esp32 start.c
LLVM Emit Object... error: <unknown>:0: Undefined temporary symbol .LBB385_2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants