Add ESP32-C6-WROOM-1U #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to select the desired footprint when adding the symbol.
The previous URL directed to the new one so this is not really a change.
pedrominatel
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149.
I based myself on the existing non-U variant and the land pattern in the datasheet.
This allows users to select the desired footprint (with and without antenna) when adding the symbol.
The previous URL directed to the new one so this is not really a change.
Consideration
I considered renaming the ESP32-C6-WROOM-1 symbol to ESP32-C6-WROOM-1/U in line with the ESP32-C6-MINI but was not convinced. On the one hand, it might help people searching for the U variant, on the other hand, people are already using the current symbol and this would effectively remove and create a new one thereby causing a breaking change.
To avoid this, I limited myself to adding the U variant to the keywords and description.
If you'd like any changes, please let me know.