Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labels of GPIO17/18 of ESP32-S2 based symbols (Fix for #138) #140

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Fix labels of GPIO17/18 of ESP32-S2 based symbols (Fix for #138) #140

merged 1 commit into from
Dec 26, 2023

Conversation

julianobst
Copy link
Contributor

Fix labels for ADC2_CH6/7 and DAC1/2 on GPIO17/18 in following symbols:

  • ESP32-S2-MINI-1_1_1 (ESP32-S2-MINI-1)
  • ESP32-S2-Saola-1_0_0 (ESP32-S2-Saola-1)
  • ESP32-S2-WROOM_1_1 (ESP32-S2-WROOM (NRND)
  • ESP32-S2-WROVER_0_0 (ESP32-S2-WROVER (NRND)

Fix labels for ADC2_CH6/7 and DAC1/2 on GPIO17/18 in following symbols:
- ESP32-S2-MINI-1_1_1 (ESP32-S2-MINI-1)
- ESP32-S2-Saola-1_0_0 (ESP32-S2-Saola-1)
- ESP32-S2-WROOM_1_1 (ESP32-S2-WROOM (NRND)
- ESP32-S2-WROVER_0_0 (ESP32-S2-WROVER (NRND)
@julianobst
Copy link
Contributor Author

This will fix issue #138

@pedrominatel pedrominatel self-assigned this Dec 26, 2023
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@pedrominatel pedrominatel merged commit 975189f into espressif:main Dec 26, 2023
@julianobst julianobst deleted the julianobst-gpio-labels branch December 26, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants