Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the GND pins of ESP32-S3-WROOM-2 #121

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix the GND pins of ESP32-S3-WROOM-2 #121

merged 1 commit into from
Sep 18, 2023

Conversation

wh201906
Copy link
Contributor

@wh201906 wh201906 commented Sep 17, 2023 •
edited
Loading

This fix is based on the existing symbol of ESP32-S3-WROOM-1

kicad-libraries/symbols/Espressif.kicad_sym

Line 5270 in c34529e

(pin power_in line (at 0 -40.64 90) (length 2.54)

Before this Fix:
图片
After this Fix:
图片

pedrominatel
pedrominatel approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wh201906 for this PR.
Looks good to me.

@pedrominatel pedrominatel added the bug Something isn't working label Sep 18, 2023
@pedrominatel pedrominatel merged commit fe676c7 into espressif:main Sep 18, 2023
@wh201906 wh201906 deleted the fix_s3_wroom_2_gnd branch September 18, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrominatel pedrominatel pedrominatel approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wh201906 @pedrominatel