Fix S3 bootloader patching (ESPTOOL-432) #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Member
|
Hi @Jason2866, I have sent this PR to our internal review. After some tests pass, this will get merged. |
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Please delete any lines which don't apply)
Description of change
Correct
BOOTLOADER_FLASH_OFFSETfrom0x1000to0x0This change fixes the following bug(s):
#727
I have tested this change with the following hardware & software combinations:
ESP32-S3 AI-Thinker board with 8MB flash and 8MB PSRAM
I have run the esptool.py automated integration tests with this change and the above hardware. The results were:
(Details here: https://github.com/espressif/esptool/blob/master/CONTRIBUTING.md#automated-integration-tests )