[eppp]: Add support for USB host -- device transport #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| \|/ +----------------+ +----------------+ | ||
| | | | serial line | | | ||
| +---+ WiFi NAT PPPoS |======== UART / SPI =======| PPPoS client | | ||
| +---+ WiFi NAT PPPoS |=== UART / SPI / SDIO =====| PPPoS client | |
Collaborator
There was a problem hiding this comment.
We could remove the “channels” from this image and phrase it as link channel or something like that.
| Tested with WiFi-NAPT example, no IRAM optimizations | ||
| Tested with WiFi-NAPT example | ||
|
|
||
| ### UART @ 3Mbauds |
Collaborator
There was a problem hiding this comment.
| Link | TCP | UDP |
|---|---|---|
| UART @ 3Mbauds | 2Mbits/s | 2Mbits/s |
| SPI @ 16MHz | 5Mbits/s | 8Mbits/s |
| SDIO | 9Mbits/s | 11Mbits/s |
| ESP_ERROR_CHECK(ret); | ||
|
|
||
| init_network_interface(); // WiFi station if withing SoC capabilities (otherwise a placeholder) | ||
| // ESP_ERROR_CHECK(esp_netif_init()); |
| ESP_GOTO_ON_FALSE((s_essl_mutex = xSemaphoreCreateMutex()), ESP_ERR_NO_MEM, err, TAG, "failed to create semaphore"); | ||
| return ret; | ||
|
|
||
| err: |
Collaborator
There was a problem hiding this comment.
Are we leaking s_card on failure?
Please also review other initialized data for cleanup, e.g. s_essl_mutex
| * @param[in] event Device event type and data | ||
| * @param[in] user_ctx Argument we passed to the device open function | ||
| */ | ||
| static void handle_event(const cdc_acm_host_dev_event_data_t *event, void *user_ctx) |
Collaborator
There was a problem hiding this comment.
Should we allow users to add a custom event handler? Maybe add a parameter to init function and use this default function if not provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #511
both eppp server and client can choose to act as USB CDC ACM host or a device.
(may need a minor refactor, as we support more and more transports)