Header fix (IDFGH-2923) #8

atlascoder · 2019-11-02T09:39:19Z

required if to build with debug info

# Conflicts: # src/include/lwip/init.h

Fix compilation of unit tests

Signed-off-by: Axel Lin <[email protected]> (cherry picked from commit 7faa4bc)

Mainly for better readability, also save NULL test while iterating the for loop. Signed-off-by: Axel Lin <[email protected]> (cherry picked from commit a2915b7)

…an be set without appending a will message The boolean condition of setting the WILL flag differs from that of appending the will message Found by Axel Lin (I fixed it the same way as Axel suggested, but I wanted a different commit message) (cherry picked from commit 6d5ddb7)

(cherry picked from commit 52f4489)

ICMPv6 should always have checksum generated for it as per RFC 3542 chapter 3.1. (cherry picked from commit 5e9df2c)

(cherry picked from commit 2b1ebda)

(cherry picked from commit 5c58e25)

(cherry picked from commit 861dab5)

oversize_used is always 0 at this point, should test oversize instead. Signed-off-by: Axel Lin <[email protected]> (cherry picked from commit e1598b0)

(cherry picked from commit 0043bf7)

Check for integer overflow when calculating memory allocation size (cherry picked from commit 9898d40)

(cherry picked from commit df8e404)

…t_oversize Both last_unsent->unsent_oversize and tcp_pcb.unsent_oversized fields are not exist, fix the comments. Signed-off-by: Axel Lin <[email protected]> (cherry picked from commit 30aedfc)

Make the intention of code more clear by using LWIP_MIN instead of open-coded. Signed-off-by: Axel Lin <[email protected]> (cherry picked from commit 141b5de)

(cherry picked from commit b198c87)

Kept the optimized version intact, see discussion in savannah bug tracker (cherry picked from commit 199c38d)

- Code duplication with etharp_raw() - No great effect on perfomance - May make reworking PBUF handling code more complicated (see bug #49914) - The check for p->type == PBUF_REF is a strange special case, too - Simon also voted to remove it (cherry picked from commit 47bac3c)

…t the beginning of the function (cherry picked from commit 7aaa888)

Accidentally used the wrong destination HW addr (cherry picked from commit 645ca84)

(cherry picked from commit ee31549)

The code didn't create an new mld group when netif is up, this will lead to the server can't find the matching netif when receiving NS(neighbor solicitation) packet

when two targets has created TCP connection, and SO_LINGER is enabled, if close the target1's socket when target1 is sending large data to target2, the crash will happen

Fix lwip crashed bug caused by sys_mbox_free()

we need to add hostname option in both DHCP discover and request for some compatibility issues with specific Huawei router.

Fix a mbox free thread-safe issue that can lead crash in sys_mbox_fetch().

fix autoip memory leak

Alvin1Zhang · 2020-03-20T01:32:09Z

@atlascoder Thanks for your contribution.

freakyxue · 2020-03-20T03:53:29Z

hi @atlascoder
this bug has been fixed.
lwip commit ID : 03230fd
By the way, lwip 2.1.2 has no such bug

david-cermak · 2020-08-21T09:07:49Z

@atlascoder Closing, since the issue is already fixed as @freakyxue mentions above.

Reproducer (in bash): base64 -d <<< "H4sIAP/9L2QCA+3WoQ2AMBSE4QoCTFHBBJfgSRF4RDfpRmgmYBpGQRBCk4ZiSfk/+fJMK+5dZRVpzSQzSs6oPierDV4y87WxLQLwE42SfNCdDyHJB9/xZwAARPbMJbUq4JJmu4JVT1cAAACfbGIqoqcMzy90eu+aBw2+N28WFgAA" | gunzip | test/fuzz/lwip_fuzz2 Crash log: ../../src/core/altcp_tcp.c:178:13: runtime error: member access within null pointer of type 'struct tcp_pcb' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../src/core/altcp_tcp.c:178:13 in AddressSanitizer:DEADLYSIGNAL ================================================================= ==192415==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000048 (pc 0x557065081703 bp 0x0aae0cb71204 sp 0x7ffd034dabc0 T0) ==192415==The signal is caused by a READ memory access. ==192415==Hint: address points to the zero page. #0 0x557065081703 in altcp_tcp_setup_callbacks /.../lwip/test/fuzz/../../src/core/altcp_tcp.c:178:19 espressif#1 0x55706508206f in altcp_tcp_setup /.../lwip/test/fuzz/../../src/core/altcp_tcp.c:189:3 espressif#2 0x55706508206f in altcp_tcp_accept /.../lwip/test/fuzz/../../src/core/altcp_tcp.c:84:5 espressif#3 0x557065095592 in tcp_input /.../lwip/test/fuzz/../../src/core/tcp_in.c:380:9 espressif#4 0x5570650e752f in ip4_input /.../lwip/test/fuzz/../../src/core/ipv4/ip4.c:743:9 espressif#5 0x55706513d4de in ethernet_input /.../lwip/test/fuzz/../../src/netif/ethernet.c:186:9 espressif#6 0x557064fe0959 in input_pkt /.../lwip/test/fuzz/fuzz_common.c:209:9 espressif#7 0x557064fdeb6a in input_pkts /.../lwip/test/fuzz/fuzz_common.c:257:9 espressif#8 0x557064fdeb6a in lwip_fuzztest /.../lwip/test/fuzz/fuzz_common.c:669:3 espressif#9 0x7ff4f578e189 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 espressif#10 0x7ff4f578e244 in __libc_start_main csu/../csu/libc-start.c:381:3 espressif#11 0x557064f20420 in _start (/.../lwip/test/fuzz/lwip_fuzz2+0x81420) (BuildId: 8680a96430d5749c90111fe9c3a3d4f881a5dbcd) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV /.../lwip/test/fuzz/../../src/core/altcp_tcp.c:178:19 in altcp_tcp_setup_callbacks ==192415==ABORTING Aborted

goldsimon and others added 30 commits April 27, 2016 22:04

Set LWIP_VERSION_RC to RC1

33955c6

Merge branch 'master' into STABLE-2_0_0

15b7555

Set LWIP_VERSION_RC to RC2

fd096a5

Merge branch 'master' into STABLE-2_0_0

a68eddb

Set version to 2.0.0 release

216bf89

Merge branch 'master' into STABLE-2_0_0

1a2a9a4

# Conflicts: # src/include/lwip/init.h

Set lwIP version to 2.0.1 RELEASE

a5a4830

Remove duplicate netif_dhcp_data() macro

76b4365

Fix compilation of unit tests

Put 2.0.1 version tag in UPGRADING document

980b219

Add MQTT to CHANGELOG (too late for 2.0.1 release...)

e5071da

mqtt: Prevent NULL pointer dereference before assertion checking

5fe195c

Signed-off-by: Axel Lin <[email protected]> (cherry picked from commit 7faa4bc)

mqtt: Slightly improve mqtt_create_request

4deaeba

Mainly for better readability, also save NULL test while iterating the for loop. Signed-off-by: Axel Lin <[email protected]> (cherry picked from commit a2915b7)

MQTT: Add check that WILL topic length must be > 0

cb97e27

(cherry picked from commit 52f4489)

lwip: fix broken default ICMPv6 handling of checksums.

2694486

ICMPv6 should always have checksum generated for it as per RFC 3542 chapter 3.1. (cherry picked from commit 5e9df2c)

Minor correction to last patch: Avoid #including socket.h in api_msg.c

d860dd7

(cherry picked from commit 2b1ebda)

Minor code readability improvement in mqtt.c

7ba2633

(cherry picked from commit 5c58e25)

Set lwIP version to 2.0.2 in doxygen script

0a73e0f

(cherry picked from commit 861dab5)

tcp_out: Fix oversize vs. space assertion test

bbe91e3

oversize_used is always 0 at this point, should test oversize instead. Signed-off-by: Axel Lin <[email protected]> (cherry picked from commit e1598b0)

Minor typo fix in tcp_out.c

fed1577

(cherry picked from commit 0043bf7)

Fix bug #50040: pbuf_alloc(..., 65534, PBUF_RAM) succeeds

1fdbda9

Check for integer overflow when calculating memory allocation size (cherry picked from commit 9898d40)

Add some parentheses for better code readability in tcp_in.c

4fe1436

(cherry picked from commit df8e404)

tcp_out: Fix comment for last_unsent->oversize_left and tcp_pcb.unsen…

e675638

…t_oversize Both last_unsent->unsent_oversize and tcp_pcb.unsent_oversized fields are not exist, fix the comments. Signed-off-by: Axel Lin <[email protected]> (cherry picked from commit 30aedfc)

tcp_out: Use LWIP_MIN instead of open-coded for better readability

90d68b4

Make the intention of code more clear by using LWIP_MIN instead of open-coded. Signed-off-by: Axel Lin <[email protected]> (cherry picked from commit 141b5de)

fix compiling TCP unit tests with IPv6 enabled

d0b0cf9

(cherry picked from commit b198c87)

Fix bug #50064: Zero-copy RX: ARP reply fails with PBUF_REF

e53c846

Kept the optimized version intact, see discussion in savannah bug tracker (cherry picked from commit 199c38d)

Optimize my last fix in etharp.c, I missed the variable declaration a…

8c6ac8e

…t the beginning of the function (cherry picked from commit 7aaa888)

Retry 1 to fix bug #50064

777d54f

Accidentally used the wrong destination HW addr (cherry picked from commit 645ca84)

Add CHANGELOG to lwIP HTML documentation

0b299f9

(cherry picked from commit ee31549)

zhangyanjiaoesp and others added 19 commits August 9, 2018 11:34

delete assert when close a connecting socket

fb5b038

fix the bug in unit test

cf5a859

add recvmsg code

2eaad50

asio udp: set the remote udp address+port

6aaed9e

ci: deploy to github

18548d1

dhcp restore last ip

3b88e84

dns.h depends on err.h

cf0db83

add code for sending gratuitous ARP periodically

e6bb433

fix the bug that failed to create socket

e6f0cab

fix the bug that IPv6 TCP connection fail

99d992c

The code didn't create an new mld group when netif is up, this will lead to the server can't find the matching netif when receiving NS(neighbor solicitation) packet

fix the crash when close socket

21a1fcb

when two targets has created TCP connection, and SO_LINGER is enabled, if close the target1's socket when target1 is sending large data to target2, the crash will happen

fix the compile bug for autoip

7e636c1

lwip: fix crash caused by sys_mbox_free

046fadd

Fix lwip crashed bug caused by sys_mbox_free()

Re-add hostname option in dhcp discover

0865edf

test: check hostname option in DHCP discover/request:

93de13b

we need to add hostname option in both DHCP discover and request for some compatibility issues with specific Huawei router.

Fix mbox thread-safe issue

e2a24de

Fix a mbox free thread-safe issue that can lead crash in sys_mbox_fetch().

Merge branch 'bugfix/autoip_memoey_leak_debug' into 'master'

fe9a58c

fix autoip memory leak

fix dns crash

3ed39f2

header fixed

3b5c8bb

github-actions bot changed the title ~~Header fix~~ Header fix (IDFGH-2923) Mar 19, 2020

david-cermak closed this Aug 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Header fix (IDFGH-2923) #8

Header fix (IDFGH-2923) #8

Uh oh!

atlascoder commented Nov 2, 2019

Uh oh!

Alvin1Zhang commented Mar 20, 2020

Uh oh!

freakyxue commented Mar 20, 2020

Uh oh!

david-cermak commented Aug 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Header fix (IDFGH-2923) #8

Header fix (IDFGH-2923) #8

Uh oh!

Conversation

atlascoder commented Nov 2, 2019

Uh oh!

Alvin1Zhang commented Mar 20, 2020

Uh oh!

freakyxue commented Mar 20, 2020

Uh oh!

david-cermak commented Aug 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants