Set "event" member to BUTTON_PRESS_REPEAT (AEGHB-312) #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before calling the BUTTON_PRESS_REPEAT callback, the "event" member should be set to "BUTTON_PRESS_REPEAT". This is currently missing.
|
|
github-actions
bot
changed the title
|
Thanks for your contribution, the code is being merged in internally! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before calling the BUTTON_PRESS_REPEAT callback, the "event" member should be set to "BUTTON_PRESS_REPEAT".
This is currently missing.
If you try "triple clicking" a button, the event member should be set to the
current event. This way if you're callback is meant to handle multiple event
types, you'll be able to distinguish the "BUTTON_PRESS_REPEAT" event from
the preceding "BUTTON_PRESS_DOWN" event.