Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledc.h - fix extern "C" to include ledc_cb_register() (IDFGH-6484) #8139

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

vortigont
Copy link
Contributor

ledc_cb_register() function is out of scope of "#ifdef __cplusplus", introduced in 9d098cc

this patch fixes linker error "undefined reference to `ledc_cb_register()" if build with cpp

@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 24, 2021
@github-actions github-actions bot changed the title ledc.h - fix extern "C" to include ledc_cb_register() ledc.h - fix extern "C" to include ledc_cb_register() (IDFGH-6484) Dec 24, 2021
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@mahavirj
Copy link
Member

sha=d4de08182eab8fc3415f20265181bf141eef7376

@mahavirj mahavirj added the PR-Sync-Merge Pull request sync as merge commit label Dec 27, 2021
@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Resolution: NA Issue resolution is unavailable labels Dec 28, 2021
@espressif-bot espressif-bot merged commit 5624dff into espressif:master Dec 28, 2021
@vortigont vortigont deleted the ledccb branch December 28, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants