Don't overwrite errno by a hard coded ENOENT (IDFGH-6378) #8036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling "open" in CHECK_AND_CALL sets a perfectly correct errno. There is no need to overwrite that with a value of ENOENT, since doing so hides lower level errors like EIO
github-actions
bot
changed the title
|
@winzkigermany could you please describe the situation you are seeing this issue in? Just so that we can add a unit test to check this behavior... |
|
The real world scenario is: The user pulls an SD card out (we're using sdmmc), and after that, you just try to fopen(...) a file. |
espressif-bot
added
Status: In Progress
|
Thank you for the PR @winzkigermany! It has been merged in f01b9a5 |
dskulina
pushed a commit
to playable-tech/esp-idf
that referenced
this pull request
Feb 4, 2022
Calling "open" in CHECK_AND_CALL sets a perfectly correct errno. There is no need to overwrite that with a value of ENOENT, since doing so hides lower level errors like EIO. Closes espressif#8036
dskulina
pushed a commit
to playable-tech/esp-idf
that referenced
this pull request
Feb 5, 2022
Calling "open" in CHECK_AND_CALL sets a perfectly correct errno. There is no need to overwrite that with a value of ENOENT, since doing so hides lower level errors like EIO. Closes espressif#8036
espressif-bot
pushed a commit
that referenced
this pull request
Feb 8, 2022
Calling "open" in CHECK_AND_CALL sets a perfectly correct errno. There is no need to overwrite that with a value of ENOENT, since doing so hides lower level errors like EIO. Closes #8036
espressif-bot
pushed a commit
that referenced
this pull request
Feb 9, 2022
Calling "open" in CHECK_AND_CALL sets a perfectly correct errno. There is no need to overwrite that with a value of ENOENT, since doing so hides lower level errors like EIO. Closes #8036
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling "open" in CHECK_AND_CALL sets a perfectly correct errno.
There is no need to overwrite that with a value of ENOENT, since doing so hides lower level errors like EIO