lwip: menuconfig option for max number of SNTP servers (IDFGH-5616) #7336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LWIP has two definess for setting max number of sntp servers: - Total number of handled servers - max number of sntp's picked via DHCP by default both values are equal to 1, but could be set separately Signed-off-by: Emil Muratov <[email protected]>
|
|
github-actions
bot
changed the title
|
Thanks for your contribution. |
david-cermak
approved these changes
Jul 30, 2021
espressif-bot
added
Status: In Progress
This could be toggled on/off, off is the default. SNTP debug option. Example update for ntp via DHCP Signed-off-by: Emil Muratov <[email protected]>
|
@david-cermak I've updated notes for menuoption, also added NTP debug option and sntp example to utilize SNTP via DHCP if build-in. |
|
@vortigont Thanks for the prompt update and addressing the concern of misconfiguration. |
espressif-bot
added
Resolution: NA
vortigont
added a commit
to vortigont/esp32-arduino-lib-builder
that referenced
this pull request
Nov 2, 2021
- increase default number of NTP servers up to 3 (match with Arduino esp8266) - activate SNTP over DHCP requests (match with Arduino esp8266) addressing issue espressif/arduino-esp32#4964 provided via espressif/esp-idf#7336
This was referenced Nov 2, 2021
me-no-dev
pushed a commit
to espressif/esp32-arduino-lib-builder
that referenced
this pull request
Dec 20, 2021
- increase default number of NTP servers up to 3 (match with Arduino esp8266) - activate SNTP over DHCP requests (match with Arduino esp8266) addressing issue espressif/arduino-esp32#4964 provided via espressif/esp-idf#7336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LWIP has two define's for setting max number of sntp servers:
by default both values are equal to 1, but could be set separately.
This is a followup for espressif/arduino-esp32#5343. Having this menuconfig option allows building lwip for arduino-esp32 with multiple sntps's supported